linux-kernel - Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c463005-3582-4bee-bd9f-cd0b415f5e65@quicinc.com>
Date: Fri, 4 Jul 2025 16:41:46 +0530
From: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@....qualcomm.com>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Michael Turquette
	<mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Ajit Pandey
	<quic_ajipan@...cinc.com>,
        Imran Shaik <quic_imrashai@...cinc.com>,
        "Taniya
 Das" <quic_tdas@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x
 compatible


On 7/3/2025 12:55 PM, Krzysztof Kozlowski wrote:
> On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
>>> -      - qcom,sc7180-videocc
>>> -      - qcom,sc7280-videocc
>>> -      - qcom,sdm845-videocc
>>> -      - qcom,sm6350-videocc
>>> -      - qcom,sm8150-videocc
>>> -      - qcom,sm8250-videocc
>>> +    oneOf:
>>> +      - enum:
>>> +          - qcom,sc7180-videocc
>>> +          - qcom,sc7280-videocc
>>> +          - qcom,sdm845-videocc
>>> +          - qcom,sm6350-videocc
>>> +          - qcom,sm8150-videocc
>>> +          - qcom,sm8250-videocc
>>> +      - items:
>>> +          - const: qcom,sc8180x-videocc
>>> +          - const: qcom,sm8150-videocc
>>>   
>>>     clocks:
>>>       minItems: 1
>>> @@ -111,6 +115,7 @@ allOf:
>>>         properties:
>>>           compatible:
>>>             enum:
>>> +            - qcom,sc8180x-videocc
>> Is there a need for this? Isn't it already covered by the SM8150 entry?
> Yes and no. Yes - some change here is needed as I explained. No - this
> exact change does not work, so it is obviously redundant.


Yes, I agree. I'll add 'contains:' throughout the schema and remove this 
compatible since anyway it matches with sm8150 compatible.


Thanks,

Satya Priya