linux-kernel - Re: [PATCH v10 02/25] crypto: iaa - New architecture for IAA device WQ comp/decomp usage & core mapping.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507051352.IIeHABGF-lkp@intel.com>
Date: Sat, 5 Jul 2025 14:00:27 +0800
From: kernel test robot <lkp@...el.com>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	hannes@...xchg.org, yosry.ahmed@...ux.dev, nphamcs@...il.com,
	chengming.zhou@...ux.dev, usamaarif642@...il.com,
	ryan.roberts@....com, 21cnbao@...il.com,
	ying.huang@...ux.alibaba.com, akpm@...ux-foundation.org,
	senozhatsky@...omium.org, linux-crypto@...r.kernel.org,
	herbert@...dor.apana.org.au, davem@...emloft.net,
	clabbe@...libre.com, ardb@...nel.org, ebiggers@...gle.com,
	surenb@...gle.com, kristen.c.accardi@...el.com,
	vinicius.gomes@...el.com
Cc: oe-kbuild-all@...ts.linux.dev, wajdi.k.feghali@...el.com,
	vinodh.gopal@...el.com, kanchana.p.sridhar@...el.com
Subject: Re: [PATCH v10 02/25] crypto: iaa - New architecture for IAA device
 WQ comp/decomp usage & core mapping.

Hi Kanchana,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master akpm-mm/mm-everything linus/master v6.16-rc4 next-20250704]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kanchana-P-Sridhar/crypto-iaa-Reorganize-the-iaa_crypto-driver-code/20250704-122613
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/20250704042323.10318-3-kanchana.p.sridhar%40intel.com
patch subject: [PATCH v10 02/25] crypto: iaa - New architecture for IAA device WQ comp/decomp usage & core mapping.
config: x86_64-randconfig-123-20250704 (https://download.01.org/0day-ci/archive/20250705/202507051352.IIeHABGF-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250705/202507051352.IIeHABGF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507051352.IIeHABGF-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/crypto/intel/iaa/iaa_crypto_main.c:94:1: sparse: sparse: symbol 'first_wq_found_lock' was not declared. Should it be static?

vim +/first_wq_found_lock +94 drivers/crypto/intel/iaa/iaa_crypto_main.c

    77	
    78	/*
    79	 * First wq probed, to use until @iaa_crypto_enabled is 1:
    80	 *
    81	 * The first wq probed will be entered in the per-CPU comp/decomp wq tables
    82	 * until the IAA compression modes are registered. This is done to facilitate
    83	 * the compress/decompress calls from the crypto testmgr resulting from
    84	 * calling crypto_register_acomp().
    85	 *
    86	 * With the new dynamic package-level rebalancing of WQs being
    87	 * discovered asynchronously and concurrently with tests
    88	 * triggered from device registration, this is needed to
    89	 * determine when it is safe for the rebalancing of decomp/comp
    90	 * WQs to de-allocate the per-package WQs and re-allocate them
    91	 * based on the latest number of IAA devices and WQs.
    92	 */
    93	static struct idxd_wq *first_wq_found;
  > 94	DEFINE_MUTEX(first_wq_found_lock);
    95	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki