linux-kernel - Re: [PATCH] i2c: omap: Fix an error handling path in omap_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <068ce076-f317-4646-99d0-c500feb02450@wanadoo.fr>
Date: Sat, 5 Jul 2025 09:59:47 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Aaro Koskinen <aaro.koskinen@....fi>,
 Andreas Kemnade <andreas@...nade.info>, Kevin Hilman <khilman@...libre.com>,
 Roger Quadros <rogerq@...nel.org>, Tony Lindgren <tony@...mide.com>,
 Janusz Krzysztofik <jmkrzyszt@...il.com>, Vignesh R <vigneshr@...com>,
 Jayesh Choudhary <j-choudhary@...com>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-omap@...r.kernel.org,
 linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: omap: Fix an error handling path in omap_i2c_probe()

Le 26/06/2025 à 00:10, Andi Shyti a écrit :
> Hi Christophe,
> 
> On Sat, Jun 14, 2025 at 04:59:26PM +0200, Christophe JAILLET wrote:
>> If an error occurs after calling mux_state_select(), mux_state_deselect()
>> should be called as already done in the remove function.
>>
>> Fixes: b6ef830c60b6 ("i2c: omap: Add support for setting mux")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> merged to i2c/i2c-host-fixes. Thanks!
> 
>> ---
>> I'm not 100% sure of the error handling path.
>>
>> Should pm_runtime_dont_use_autosuspend() be called after the err_disable_pm
>> label? (to match the calling order)
> 
> Yes, I think you are right here.
> 
>> Also, should errors from omap_i2c_init() be handled?
> 
> Yes, if it fails it should be handled.
> 
> Thanks for the two reports. Do you have time to fix them or
> can I go ahead and do it?

I've sent a patch for each issue.

Feel free to take the lead if not correct. As said in the cover letter, 
I'm not completely confident with them.

CJ

> 
> Thanks,
> Andi
> 
>