linux-kernel - Re: [PATCH RFT net-next 04/10] soc: sunxi: sram: register regmap as syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250705114527.73b15356@rpi>
Date: Sat, 5 Jul 2025 11:45:27 +0200
From: Per Larsson <per@...vencia.se>
To: Chen-Yu Tsai <wens@...e.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jernej Skrabec <jernej@...nel.org>, Samuel Holland
 <samuel@...lland.org>, netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Andre Przywara <andre.przywara@....com>
Subject: Re: [PATCH RFT net-next 04/10] soc: sunxi: sram: register regmap as
 syscon

On Wed, 2 Jul 2025 13:01:04 +0800
Chen-Yu Tsai <wens@...e.org> wrote:

> On Wed, Jul 2, 2025 at 12:58 AM Chen-Yu Tsai <wens@...nel.org> wrote:
> >
> > From: Chen-Yu Tsai <wens@...e.org>
> >
> > Until now, if the system controller had a ethernet controller glue
> > layer control register, a limited access regmap would be registered
> > and tied to the system controller struct device for the ethernet
> > driver to use.

"Until now"? 
Does that description (i.e. something that used to happen, but not
after the patch) really match the change?

- snip -

> > +               ret = of_syscon_register_regmap(dev->of_node,
> > regmap);
> > +               if (IS_ERR(ret))  
> 
> BroderTuck on IRC pointed out that this gives a compiler warning.
> Indeed it is incorrect. It should test `ret` directly.
> 
> ChenYu
> 

Regards
Per Larsson, known as BroderTuck on #linux-sunxi