linux-kernel - Re: [PATCH] regulator: tps6286x-regulator: Enable REGCACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGj1hAAg3nM4zV70@xhacker>
Date: Sat, 5 Jul 2025 17:51:00 +0800
From: Jisheng Zhang <jszhang@...nel.org>
To: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: tps6286x-regulator: Enable REGCACHE_MAPLE

On Sun, Jun 29, 2025 at 05:51:07PM +0800, Jisheng Zhang wrote:
> Enable regmap cache to reduce i2c transactions and corresponding
> interrupts if regulator is accessed frequently.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>  drivers/regulator/tps6286x-regulator.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/regulator/tps6286x-regulator.c b/drivers/regulator/tps6286x-regulator.c
> index 75f441f36de7..778f169b0acc 100644
> --- a/drivers/regulator/tps6286x-regulator.c
> +++ b/drivers/regulator/tps6286x-regulator.c
> @@ -19,13 +19,22 @@
>  #define TPS6286X_CONTROL_FPWM	BIT(4)
>  #define TPS6286X_CONTROL_SWEN	BIT(5)
>  
> +#define TPS6286X_STATUS		0x05
> +
>  #define TPS6286X_MIN_MV		400
>  #define TPS6286X_MAX_MV		1675
>  #define TPS6286X_STEP_MV	5
>  
> +static bool tps6287x_volatile_reg(struct device *dev, unsigned int reg)

Hi Mark,

I made a copy and paste error here: should be tps6286x_volatile_reg
I have seen v1 has been merged, so how to cope with this? Do I need
to send a v2?

Sorry for catching this a bit late.

Thanks
> +{
> +	return reg == TPS6286X_STATUS;
> +}
> +
>  static const struct regmap_config tps6286x_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
> +	.cache_type = REGCACHE_MAPLE,
> +	.volatile_reg = tps6287x_volatile_reg,

ditto

>  };
>  
>  static int tps6286x_set_mode(struct regulator_dev *rdev, unsigned int mode)
> -- 
> 2.49.0
>