linux-kernel - Re: [PATCH] rust: miscdevice: remove unnecessary import

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ-ks9nJhBDQtVUGNJVPmtrK6M8S9_Q+vpVGeSLtspJNaaX+nw@mail.gmail.com>
Date: Sat, 5 Jul 2025 11:56:19 -0400
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: miscdevice: remove unnecessary import

On Fri, Jul 4, 2025 at 3:50 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> `kernel::str::CStr` is included in the prelude.
>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
>  rust/kernel/miscdevice.rs | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
> index 288f40e79906..8309d656088a 100644
> --- a/rust/kernel/miscdevice.rs
> +++ b/rust/kernel/miscdevice.rs
> @@ -17,7 +17,6 @@
>      mm::virt::VmaNew,
>      prelude::*,
>      seq_file::SeqFile,
> -    str::CStr,
>      types::{ForeignOwnable, Opaque},
>  };
>  use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};
>
> ---
> base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
> change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece
>
> Best regards,
> --
> Tamir Duberstein <tamird@...il.com>
>

Oops, should have sent this to Greg. Sent
https://lore.kernel.org/all/20250705-miscdevice-maintainers-v1-1-9a6b67f7602f@gmail.com/
to make this easier in the future.