linux-kernel - Re: [PATCH v3 RESEND] media: i2c: Add OV05C10 camera sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGo9sDWSiZGvOhR4@kekkonen.localdomain>
Date: Sun, 6 Jul 2025 09:11:12 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: "Nirujogi, Pratap" <pnirujog@....com>
Cc: "Yan, Dongcheng" <dongcheng.yan@...ux.intel.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Hao Yao <hao.yao@...el.com>,
	Pratap Nirujogi <pratap.nirujogi@....com>, mchehab@...nel.org,
	hverkuil@...all.nl, bryan.odonoghue@...aro.org, krzk@...nel.org,
	dave.stevenson@...pberrypi.com, hdegoede@...hat.com,
	jai.luthra@...asonboard.com, tomi.valkeinen@...asonboard.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	benjamin.chan@....com, bin.du@....com, grosikop@....com,
	king.li@....com, dantony@....com, vengutta@....com,
	dongcheng.yan@...el.com, jason.z.chen@...el.com, jimmy.su@...el.com
Subject: Re: [PATCH v3 RESEND] media: i2c: Add OV05C10 camera sensor driver

Hi Pratap,

On Wed, Jul 02, 2025 at 12:47:40PM -0400, Nirujogi, Pratap wrote:
> > > If you have a spec of OV05C10 (I assume you do, as the developer of this
> > > driver), it is not a issue.
> > > Take P0:0x14 as an example, it's named as DPLL_NC_SEL in spec and set to
> > > 0x78 in your reglist ov05c10_2888x1808_regs. If define all named
> > > registers rather than the confusing magic hardcode, the driver code will
> > > be more readable and easy to review.
> > > I think this is what Sakari thought.
> > 
> > Yes. And even if it happens that a register write slips to a wrong list,
> > we can fix it later.
> > 
> I agree with the suggestion on proper naming of register offsets, but
> unfortunately we lack access to the spec. We are completely relying on the
> sensor vendor for these sequences, which they are not willing to share the
> details.

I find it difficult to believe a company such as AMD would use a camera
sensor without having documentation on it. It is essentially required for
hardware design, too.

Have you asked around?

-- 
Kind regards,

Sakari Ailus