lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250706103708.65de7569@jic23-huawei> Date: Sun, 6 Jul 2025 10:37:08 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Andrew Ijano <andrew.ijano@...il.com> Cc: andrew.lopes@...mni.usp.br, gustavobastos@....br, dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org, jstephan@...libre.com, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v6 3/4] iio: accel: sca3000: use lock guards > > > - ret = sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, > > > + return sca3000_write_reg(st, SCA3000_REG_INT_MASK_ADDR, > > This adds a character to this line which means that either the indent of > > the following lines was previously wrong, or it is now. > > I think you need to add a space to the following lines. > > > > Check for other similar cases. > > > > > ret & > > > ~(SCA3000_REG_INT_MASK_RING_THREE_QUARTER | > > > SCA3000_REG_INT_MASK_RING_HALF | > > > SCA3000_REG_INT_MASK_ALL_INTS)); > > Hm, correct me if I'm mistaken but I couldn't find this extra > character, I used the same number of tabs in both cases. Even in this > email it shows as having the same number of white spaces. return sca3000_write_reg( is one character longer than ret = sca3000_write_reg( and seeing as parameters on later lines should align just after this they all need one additional space. > > Thanks, > Andrew
Powered by blists - more mailing lists