lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250706-fresh-meaty-cougar-5af170@krzk-bin> Date: Sun, 6 Jul 2025 11:40:37 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Pritam Manohar Sutar <pritam.sutar@...sung.com> Cc: vkoul@...nel.org, kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, alim.akhtar@...sung.com, andre.draszik@...aro.org, peter.griffin@...aro.org, neil.armstrong@...aro.org, kauschluss@...root.org, ivo.ivanov.ivanov1@...il.com, m.szyprowski@...sung.com, s.nawrocki@...sung.com, linux-phy@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, rosa.pila@...sung.com, dev.tailor@...sung.com, faraz.ata@...sung.com, muhammed.ali@...sung.com, selvarasu.g@...sung.com Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible On Tue, Jul 01, 2025 at 05:37:01PM +0530, Pritam Manohar Sutar wrote: > Add a dedicated compatible string for USB HS phy found in this SoC. > The SoC requires two clocks, named "phy" and "ref" (same as clocks > required by Exynos850). > > It also requires various power supplies (regulators) for the internal > circuitry to work. The required voltages are: > * avdd075_usb - 0.75v > * avdd18_usb20 - 1.8v > * avdd33_usb20 - 3.3v > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> No, really. Look: > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@...sung.com> > --- > .../bindings/phy/samsung,usb3-drd-phy.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > index e906403208c0..2e29ff749bba 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml > @@ -34,6 +34,7 @@ properties: > - samsung,exynos7870-usbdrd-phy > - samsung,exynos850-usbdrd-phy > - samsung,exynos990-usbdrd-phy > + - samsung,exynosautov920-usbdrd-phy > > clocks: > minItems: 1 > @@ -110,6 +111,15 @@ properties: > vddh-usbdp-supply: > description: VDDh power supply for the USB DP phy. > > + avdd075_usb-supply: > + description: 0.75V power supply for USB phy > + > + avdd18_usb20-supply: > + description: 1.8V power supply for USB phy > + > + avdd33_usb20-supply: > + description: 3.3V power supply for USB phy > + None of these were here. Follow DTS coding style... but why are you adding completely new supplies? > required: > - compatible > - clocks > @@ -235,6 +245,33 @@ allOf: > > reg-names: > maxItems: 1 > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,exynosautov920-usbdrd-phy > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 > + > + clock-names: > + items: > + - const: phy > + - const: ref > + > + reg: > + maxItems: 1 > + > + reg-names: > + maxItems: 1 > + > + required: > + - avdd075_usb-supply > + - avdd18_usb20-supply > + - avdd33_usb20-supply Neither was this entire diff hunk here. This was part of other block for a reason. NAK Best regards, Krzysztof
Powered by blists - more mailing lists