[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250706095705.1386-1-khaliidcaliy@gmail.com>
Date: Sun, 6 Jul 2025 09:57:00 +0000
From: Khalid Ali <khaliidcaliy@...il.com>
To: ardb@...nel.org,
paul.walmsley@...ive.com,
palmer@...belt.com,
aou@...s.berkeley.edu,
alex@...ti.fr
Cc: gargaditya08@...e.com,
jonathan@...ek.ca,
kees@...nel.org,
linux-efi@...r.kernel.org,
linux-riscv@...ts.infradead.org,
lukas@...ner.de,
linux-kernel@...r.kernel.org,
Khalid Ali <khaliidcaliy@...il.com>
Subject: [PATCH v2 1/2] efi/libstub: Print error message if efi_allocate_bootparams() fails
From: Khalid Ali <khaliidcaliy@...il.com>
Print error message in case efi_allocate_bootparams() fails before exit.
Change the direct call of efi_exit() to "goto fail". This allows the
general error message in "fail" label to get printed.
Signed-off-by: Khalid Ali <khaliidcaliy@...il.com>
---
drivers/firmware/efi/libstub/x86-stub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
index cafc90d4caaf..13d8eba06e4b 100644
--- a/drivers/firmware/efi/libstub/x86-stub.c
+++ b/drivers/firmware/efi/libstub/x86-stub.c
@@ -824,7 +824,7 @@ void __noreturn efi_stub_entry(efi_handle_t handle,
if (!IS_ENABLED(CONFIG_EFI_HANDOVER_PROTOCOL) || !boot_params) {
status = efi_allocate_bootparams(handle, &boot_params);
if (status != EFI_SUCCESS)
- efi_exit(handle, status);
+ goto fail;
}
hdr = &boot_params->hdr;
--
2.49.0
Powered by blists - more mailing lists