lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <215f6090-d421-4fe2-b99e-e91cb1bc26a0@intel.com> Date: Sun, 6 Jul 2025 14:01:14 +0300 From: Mor Bar-Gabay <morx.bar.gabay@...el.com> To: Song Yoong Siang <yoong.siang.song@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "David S . Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, "Alexei Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, "Jesper Dangaard Brouer" <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, Vinicius Costa Gomes <vinicius.gomes@...el.com>, Jonathan Corbet <corbet@....net>, Przemek Kitszel <przemyslaw.kitszel@...el.com>, "Shinas Rasheed" <srasheed@...vell.com>, Kevin Tian <kevin.tian@...el.com>, "Brett Creeley" <brett.creeley@....com>, Blanco Alcaine Hector <hector.blanco.alcaine@...el.com>, Joshua Hay <joshua.a.hay@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, Jacob Keller <jacob.e.keller@...el.com>, Kurt Kanzenbach <kurt@...utronix.de>, Marcin Szycik <marcin.szycik@...ux.intel.com>, Brett Creeley <bcreeley@....com> CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [Intel-wired-lan] [PATCH iwl-next, v3 2/2] igc: Add wildcard rule support to ethtool NFC using Default Queue On 20/06/2025 13:02, Song Yoong Siang wrote: > Introduce support for a lowest priority wildcard (catch-all) rule in > ethtool's Network Flow Classification (NFC) for the igc driver. The > wildcard rule directs all unmatched network traffic, including traffic not > captured by Receive Side Scaling (RSS), to a specified queue. This > functionality utilizes the Default Queue feature available in I225/I226 > hardware. > > The implementation has been validated on Intel ADL-S systems with two > back-to-back connected I226 network interfaces. > > Testing Procedure: > 1. On the Device Under Test (DUT), verify the initial statistic: > $ ethtool -S enp1s0 | grep rx_q.*packets > rx_queue_0_packets: 0 > rx_queue_1_packets: 0 > rx_queue_2_packets: 0 > rx_queue_3_packets: 0 > > 2. From the Link Partner, send 10 ARP packets: > $ arping -c 10 -I enp170s0 169.254.1.2 > > 3. On the DUT, verify the packet reception on Queue 0: > $ ethtool -S enp1s0 | grep rx_q.*packets > rx_queue_0_packets: 10 > rx_queue_1_packets: 0 > rx_queue_2_packets: 0 > rx_queue_3_packets: 0 > > 4. On the DUT, add a wildcard rule to route all packets to Queue 3: > $ sudo ethtool -N enp1s0 flow-type ether queue 3 > > 5. From the Link Partner, send another 10 ARP packets: > $ arping -c 10 -I enp170s0 169.254.1.2 > > 6. Now, packets are routed to Queue 3 by the wildcard (Default Queue) rule: > $ ethtool -S enp1s0 | grep rx_q.*packets > rx_queue_0_packets: 10 > rx_queue_1_packets: 0 > rx_queue_2_packets: 0 > rx_queue_3_packets: 10 > > 7. On the DUT, add a EtherType rule to route ARP packet to Queue 1: > $ sudo ethtool -N enp1s0 flow-type ether proto 0x0806 queue 1 > > 8. From the Link Partner, send another 10 ARP packets: > $ arping -c 10 -I enp170s0 169.254.1.2 > > 9. Now, packets are routed to Queue 1 by the EtherType rule because it is > higher priority than the wildcard (Default Queue) rule: > $ ethtool -S enp1s0 | grep rx_q.*packets > rx_queue_0_packets: 10 > rx_queue_1_packets: 10 > rx_queue_2_packets: 0 > rx_queue_3_packets: 10 > > 10. On the DUT, delete all the NFC rules: > $ sudo ethtool -N enp1s0 delete 63 > $ sudo ethtool -N enp1s0 delete 64 > > 11. From the Link Partner, send another 10 ARP packets: > $ arping -c 10 -I enp170s0 169.254.1.2 > > 12. Now, packets are routed to Queue 0 because the value of Default Queue > is reset back to 0: > $ ethtool -S enp1s0 | grep rx_q.*packets > rx_queue_0_packets: 20 > rx_queue_1_packets: 10 > rx_queue_2_packets: 0 > rx_queue_3_packets: 10 > > Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de> > Co-developed-by: Blanco Alcaine Hector <hector.blanco.alcaine@...el.com> > Signed-off-by: Blanco Alcaine Hector <hector.blanco.alcaine@...el.com> > Signed-off-by: Song Yoong Siang <yoong.siang.song@...el.com> > --- > drivers/net/ethernet/intel/igc/igc.h | 11 +++++++--- > drivers/net/ethernet/intel/igc/igc_defines.h | 1 + > drivers/net/ethernet/intel/igc/igc_ethtool.c | 18 ++++++++++++++++ > drivers/net/ethernet/intel/igc/igc_main.c | 22 ++++++++++++++++++++ > 4 files changed, 49 insertions(+), 3 deletions(-) > Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>
Powered by blists - more mailing lists