linux-kernel - Re: [RFC PATCH 10/14] mm/damon/vaddr: put pid in cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250706214803.56634-1-sj@kernel.org>
Date: Sun,  6 Jul 2025 14:48:03 -0700
From: SeongJae Park <sj@...nel.org>
To: SeongJae Park <sj@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	damon@...ts.linux.dev,
	kernel-team@...a.com,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [RFC PATCH 10/14] mm/damon/vaddr: put pid in cleanup_target()

On Sun,  6 Jul 2025 13:00:14 -0700 SeongJae Park <sj@...nel.org> wrote:

> Implement cleanup_target() callback for [f]vaddr, which calls put_pid()
> for each target that will be destroyed.  Also remove redundant put_pid()
> calls in core and sysfs, which was required to be done redundantly due
> to the lack of such self cleanup in vaddr.
> 
> Signed-off-by: SeongJae Park <sj@...nel.org>
> ---
>  mm/damon/core.c  |  2 --
>  mm/damon/sysfs.c | 10 ++--------
>  mm/damon/vaddr.c |  6 ++++++
>  3 files changed, 8 insertions(+), 10 deletions(-)

This patch forgot removing put_pid() from DAMON sample modules.  I will add
below fixup on the next version.


Thanks,
SJ

[...]
---------------------- >8 --------------------------
diff --git a/samples/damon/prcl.c b/samples/damon/prcl.c
index d3215699a5f4..60a84fffed57 100644
--- a/samples/damon/prcl.c
+++ b/samples/damon/prcl.c
@@ -120,8 +120,6 @@ static void damon_sample_prcl_stop(void)
                damon_stop(&ctx, 1);
                damon_destroy_ctx(ctx);
        }
-       if (target_pidp)
-               put_pid(target_pidp);
 }

 static bool init_called;
diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c
index fb24190d2fc0..82a014c53cec 100644
--- a/samples/damon/wsse.c
+++ b/samples/damon/wsse.c
@@ -100,8 +100,6 @@ static void damon_sample_wsse_stop(void)
                damon_stop(&ctx, 1);
                damon_destroy_ctx(ctx);
        }
-       if (target_pidp)
-               put_pid(target_pidp);
 }

 static bool init_called;