linux-kernel - Re: [PATCH 1/3] power: supply: core: Add power_supply_get/set_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6lgsjfgug5mvsj55n3hc2egvi5hjfemsxuhsfkookgpqrzgqfr@woud4h7bdhvj>
Date: Mon, 7 Jul 2025 01:14:10 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Armin Wolf <W_Armin@....de>, Hans de Goede <hansg@...nel.org>, 
	Hans de Goede <hdegoede@...hat.com>, linux-pm@...r.kernel.org, platform-driver-x86@...r.kernel.org, 
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] power: supply: core: Add
 power_supply_get/set_property_direct()

Hi,

On Mon, Jun 30, 2025 at 11:58:39AM +0300, Ilpo Järvinen wrote:
> On Sat, 28 Jun 2025, Armin Wolf wrote:
> 
> > Am 28.06.25 um 11:25 schrieb Hans de Goede:
> > 
> > > Hi Armin,
> > > 
> > > On 27-Jun-25 10:51 PM, Armin Wolf wrote:
> > > > Power supply extensions might want to interact with the underlying
> > > > power supply to retrieve data like serial numbers, charging status
> > > > and more. However doing so causes psy->extensions_sem to be locked
> > > > twice, possibly causing a deadlock.
> > > > 
> > > > Provide special variants of power_supply_get/set_property() that
> > > > ignore any power supply extensions and thus do not touch the
> > > > associated psy->extensions_sem lock.
> > > > 
> > > > Suggested-by: Hans de Goede <hansg@...nel.org>
> > > > Signed-off-by: Armin Wolf <W_Armin@....de>
> > > Thank you for your work on this.
> > > 
> > > The entire series looks good to me:
> > > 
> > > Reviewed-by: Hans de Goede <hansg@...nel.org>
> > > 
> > > for the series.
> > > 
> > > There is the question of how to merge this. I think it might
> > > be best for the entire series to go through the power-supply
> > > tree.
> > > 
> > > Ilpo would that work for you and if yes can we have your ack ?
> > > 
> > > Sebastian, IMHO this should be merged as fixed not as for-next
> > > material.
> > > 
> > > Regards,
> > > 
> > > Hans
> > 
> > Personally i would prefer to merge this through the pdx86 tree as the
> > uniwill-laptop driver currently under review will also require this
> > functionality.
> 
> Sebastian, are you okay if I take this through pdx86 fixes branch as 
> requested by Armin? If yes, can I have your ack please.

Sorry, took me a bit to figure out if that works, since the core is
also patched in my next branch. But I think git should figure
everything out on its own. Feel free to merge the whole series.

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)