linux-kernel - Re: [PATCH 4/4] arm64: dts: allwinner: a523: Add power controller device nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250707003710.1d4a3ed0@minigeek.lan>
Date: Mon, 7 Jul 2025 00:37:10 +0100
From: Andre Przywara <andre.przywara@....com>
To: Chen-Yu Tsai <wens@...nel.org>
Cc: Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej@...nel.org>, Samuel
 Holland <samuel@...lland.org>, Ulf Hansson <ulf.hansson@...aro.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, linux-sunxi@...ts.linux.dev,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: allwinner: a523: Add power controller
 device nodes

On Fri, 27 Jun 2025 23:29:18 +0800
Chen-Yu Tsai <wens@...nel.org> wrote:

> From: Chen-Yu Tsai <wens@...e.org>
> 
> The A523 SoC family has two power controllers, one based on the existing
> PPU, and one newer one based on ARM's PCK-600.
> 
> Add device nodes for both of them.

Compared against the manual, that matches up. Might be worth to mention
the reliance on your RST_BUS_R_PPU0 patch, otherwise some bots might
scream.

> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 6f62201fd739..255e0ef98219 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -7,6 +7,8 @@
>  #include <dt-bindings/clock/sun55i-a523-r-ccu.h>
>  #include <dt-bindings/reset/sun55i-a523-ccu.h>
>  #include <dt-bindings/reset/sun55i-a523-r-ccu.h>
> +#include <dt-bindings/power/allwinner,sun55i-a523-ppu.h>
> +#include <dt-bindings/power/allwinner,sun55i-a523-pck600.h>
>  
>  / {
>  	interrupt-parent = <&gic>;
> @@ -576,6 +578,14 @@ mdio0: mdio {
>  			};
>  		};
>  
> +		ppu: power-controller@...1400 {
> +			compatible = "allwinner,sun55i-a523-ppu";
> +			reg = <0x07001400 0x400>;
> +			clocks = <&r_ccu CLK_BUS_R_PPU1>;
> +			resets = <&r_ccu RST_BUS_R_PPU1>;
> +			#power-domain-cells = <1>;
> +		};
> +
>  		r_ccu: clock-controller@...0000 {
>  			compatible = "allwinner,sun55i-a523-r-ccu";
>  			reg = <0x7010000 0x250>;
> @@ -622,6 +632,14 @@ r_i2c_pins: r-i2c-pins {
>  			};
>  		};
>  
> +		pck600: power-controller@...0000 {
> +			compatible = "allwinner,sun55i-a523-pck-600";
> +			reg = <0x07060000 0x8000>;
> +			clocks = <&r_ccu CLK_BUS_R_PPU0>;
> +			resets = <&r_ccu RST_BUS_R_PPU0>;
> +			#power-domain-cells = <1>;
> +		};
> +
>  		r_i2c0: i2c@...1400 {
>  			compatible = "allwinner,sun55i-a523-i2c",
>  				     "allwinner,sun8i-v536-i2c",