linux-kernel - Re: [PATCH v5 4/6] platform/x86: samsung-galaxybook: Transition new firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e0521b9-a3eb-45f7-aa97-250fb48d1c18@t-8ch.de>
Date: Sun, 6 Jul 2025 10:28:16 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Kurt Borja <kuurtb@...il.com>
Cc: Hans de Goede <hdegoede@...hat.com>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, Joshua Grisham <josh@...huagrisham.com>, 
	Mark Pearson <mpearson-lenovo@...ebb.ca>, Armin Wolf <W_Armin@....de>, 
	Mario Limonciello <mario.limonciello@....com>, Antheas Kapenekakis <lkml@...heas.dev>, 
	"Derek J. Clark" <derekjohn.clark@...il.com>, Prasanth Ksr <prasanth.ksr@...l.com>, 
	Jorge Lopez <jorge.lopez2@...com>, platform-driver-x86@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dell.Client.Kernel@...l.com
Subject: Re: [PATCH v5 4/6] platform/x86: samsung-galaxybook: Transition new
 firmware_attributes API

On 2025-07-05 00:33:59-0300, Kurt Borja wrote:
> Transition to new firmware_attributes API.
> 
> Defining firmware_attributes groups statically through
> DEFINE_FWAT_ENUM_GROUP() incurs in a minor ABI change. In particular the
> display_name_language_code attribute is no longer created. Fortunately,
> this doesn't break user-space compatibility, because this attribute is
> not required, neither by the ABI specification nor by user-space tools.
> 
> Signed-off-by: Kurt Borja <kuurtb@...il.com>
> ---
>  drivers/platform/x86/samsung-galaxybook.c | 244 ++++++++----------------------
>  1 file changed, 61 insertions(+), 183 deletions(-)

<snip>

>  
>  static int galaxybook_fw_attrs_init(struct samsung_galaxybook *galaxybook)
>  {
> +	struct fwat_device *fdev;
>  	bool value;
>  	int err;
>  
> -	err = devm_mutex_init(&galaxybook->platform->dev, &galaxybook->fw_attr_lock);

The mutex is still used, so this can't be removed.

> -	if (err)
> -		return err;
> -

<snip>