linux-kernel - Re: [PATCH v7 5/6] power: supply: pf1550: add battery charger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aGvjWbd9FRTuqWNN@fedora>
Date: Mon, 7 Jul 2025 11:10:17 -0400
From: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Frank Li <Frank.li@....com>, imx@...ts.linux.dev,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, linux-pm@...r.kernel.org,
	Abel Vesa <abelvesa@...nel.org>, Abel Vesa <abelvesa@...ux.com>,
	Robin Gong <b38343@...escale.com>, Robin Gong <yibin.gong@....com>,
	Enric Balletbo i Serra <eballetbo@...il.com>
Subject: Re: [PATCH v7 5/6] power: supply: pf1550: add battery charger support

On Mon, Jul 07, 2025 at 01:33:36AM +0200, Sebastian Reichel wrote:
> Hello Samuel,
> 
> On Wed, Jun 25, 2025 at 10:19:49AM -0400, Samuel Kayode wrote:
> > The pf1550 charger receives a VBUS power input which can be provided either by
> > an AC adapter or a USB bus. A depleted battery is charged using the VBUS power
> > input (VBUSIN). When no power is supplied to VBUSIN, the pf1550 switches the
> > load to the connected non-depleted battery.
> > 
> > I could have two power_supply_desc, one for battery and one for the external
> > power?
> 
> That's acceptable. But don't you have a fuel-gauge for the battery?
> If you register two POWER_SUPPLY_TYPE_BATTERY devices, then your
> board should have two batteries. If you have a fuel-gauge it will
> very likely provide much better battery data then anything you get
> out of pf1550.

The PMIC unfortunately does not include a fuel-gauge.

I intend on having POWER_SUPPLY_TYPE_MAINS for the external power supply
(AC adapter or USB bus) and POWER_SUPPLY_TYPE_BATTERY for the battery.

Thanks,
Sam