linux-kernel - RE: [PATCH 3/4] sched/rt: Split root_domain->rto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL1PR11MB60035E71ABA41C3F26D7B212964FA@BL1PR11MB6003.namprd11.prod.outlook.com>
Date: Mon, 7 Jul 2025 11:36:52 +0000
From: "Deng, Pan" <pan.deng@...el.com>
To: lkp <lkp@...el.com>, "mingo@...nel.org" <mingo@...nel.org>
CC: "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
	"oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Li, Tianyou"
	<tianyou.li@...el.com>, "tim.c.chen@...ux.intel.com"
	<tim.c.chen@...ux.intel.com>, "Chen, Yu C" <yu.c.chen@...el.com>
Subject: RE: [PATCH 3/4] sched/rt: Split root_domain->rto_count to
 per-NUMA-node counters

The issue arises from redundant functions when CONFIG_SMP is disabled, it will be addressed along with other feedback in the next version.

Best Regards
Pan

> -----Original Message-----
> From: lkp <lkp@...el.com>
> Sent: Monday, July 7, 2025 2:53 PM
> To: Deng, Pan <pan.deng@...el.com>; mingo@...nel.org
> Cc: llvm@...ts.linux.dev; oe-kbuild-all@...ts.linux.dev; linux-
> kernel@...r.kernel.org; Li, Tianyou <tianyou.li@...el.com>;
> tim.c.chen@...ux.intel.com; Chen, Yu C <yu.c.chen@...el.com>; Deng, Pan
> <pan.deng@...el.com>
> Subject: Re: [PATCH 3/4] sched/rt: Split root_domain->rto_count to per-NUMA-
> node counters
> 
> Hi Pan,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on v6.16-rc5]
> [also build test WARNING on linus/master] [cannot apply to tip/sched/core
> peterz-queue/sched/core tip/master tip/auto-latest next-20250704] [If your
> patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Pan-Deng/sched-rt-
> Optimize-cpupri_vec-layout-to-mitigate-cache-line-contention/20250707-
> 131831
> base:   v6.16-rc5
> patch link:
> https://lore.kernel.org/r/2c1e1dbacaddd881f3cca340ece1f9268029b620.1751
> 852370.git.pan.deng%40intel.com
> patch subject: [PATCH 3/4] sched/rt: Split root_domain->rto_count to per-
> NUMA-node counters
> config: arm-allnoconfig (https://download.01.org/0day-
> ci/archive/20250707/202507071418.sFa0bilv-lkp@...el.com/config)
> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project
> 01c97b4953e87ae455bd4c41e3de3f0f0f29c61c)
> reproduce (this is a W=1 build): (https://download.01.org/0day-
> ci/archive/20250707/202507071418.sFa0bilv-lkp@...el.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of the
> same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes:
> | https://lore.kernel.org/oe-kbuild-all/202507071418.sFa0bilv-lkp@intel.
> | com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from kernel/sched/build_policy.c:52:
>    kernel/sched/rt.c:496:21: error: unknown type name 'atomic_tp'; did you
> mean 'atomic_t'?
>      496 | int rto_counts_init(atomic_tp **rto_counts)
>          |                     ^~~~~~~~~
>          |                     atomic_t
>    include/linux/types.h:183:3: note: 'atomic_t' declared here
>      183 | } atomic_t;
>          |   ^
>    In file included from kernel/sched/build_policy.c:52:
> >> kernel/sched/rt.c:496:5: warning: no previous prototype for function
> >> 'rto_counts_init' [-Wmissing-prototypes]
>      496 | int rto_counts_init(atomic_tp **rto_counts)
>          |     ^
>    kernel/sched/rt.c:496:1: note: declare 'static' if the function is not intended to
> be used outside of this translation unit
>      496 | int rto_counts_init(atomic_tp **rto_counts)
>          | ^
>          | static
>    kernel/sched/rt.c:501:25: error: unknown type name 'atomic_tp'; did you
> mean 'atomic_t'?
>      501 | void rto_counts_cleanup(atomic_tp *rto_counts)
>          |                         ^~~~~~~~~
>          |                         atomic_t
>    include/linux/types.h:183:3: note: 'atomic_t' declared here
>      183 | } atomic_t;
>          |   ^
>    In file included from kernel/sched/build_policy.c:52:
> >> kernel/sched/rt.c:501:6: warning: no previous prototype for function
> >> 'rto_counts_cleanup' [-Wmissing-prototypes]
>      501 | void rto_counts_cleanup(atomic_tp *rto_counts)
>          |      ^
>    kernel/sched/rt.c:501:1: note: declare 'static' if the function is not intended to
> be used outside of this translation unit
>      501 | void rto_counts_cleanup(atomic_tp *rto_counts)
>          | ^
>          | static
>    2 warnings and 2 errors generated.
> 
> 
> vim +/rto_counts_init +496 kernel/sched/rt.c
> 
>    495
>  > 496	int rto_counts_init(atomic_tp **rto_counts)
>    497	{
>    498		return 0;
>    499	}
>    500
>  > 501	void rto_counts_cleanup(atomic_tp *rto_counts)
>    502	{
>    503	}
>    504
> 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki