linux-kernel - Re: [PATCH] driver core: auxiliary bus: fix OF node leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1jjz4irbmq.fsf@starbuckisacylon.baylibre.com>
Date: Tue, 08 Jul 2025 16:38:21 +0200
From: Jerome Brunet <jbrunet@...libre.com>
To: Johan Hovold <johan@...nel.org>
Cc: Leon Romanovsky <leon@...nel.org>,  Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  Dave Ertman <david.m.ertman@...el.com>,
  Ira Weiny <ira.weiny@...el.com>,  "Rafael J. Wysocki"
 <rafael@...nel.org>,  Danilo Krummrich <dakr@...nel.org>,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: auxiliary bus: fix OF node leak

On Tue 08 Jul 2025 at 12:04, Johan Hovold <johan@...nel.org> wrote:

> On Tue, Jul 08, 2025 at 12:59:08PM +0300, Leon Romanovsky wrote:
>> On Tue, Jul 08, 2025 at 10:46:54AM +0200, Johan Hovold wrote:
>> > Make sure to drop the OF node reference taken when creating an auxiliary
>> > device using auxiliary_device_create() when the device is later
>> > released.
>> 
>> I'm probably missing something, but random grep for the
>> device_set_of_node_from_dev() callers shows that none of them are
>> calling to of_node_put() explicitly.
>
> Yeah, the platform bus code takes care of dropping the reference for
> platform devices.

There is an of_node_get() that needs balancing indeed, Thanks

Reviewed-by: Jerome Brunet <jbrunet@...libre.com>

>
> Johan

-- 
Jerome