[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DB6RCGL55G2W.3PXSXQI980ELN@kernel.org>
Date: Tue, 08 Jul 2025 16:53:18 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Andreas Hindborg" <a.hindborg@...nel.org>, "Miguel Ojeda"
<miguel.ojeda.sandonis@...il.com>
Cc: "Oliver Mangold" <oliver.mangold@...me>, "Miguel Ojeda"
<ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun Feng"
<boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Alice Ryhl"
<aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Asahi Lina"
<lina+kernel@...hilina.net>, <rust-for-linux@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v11 1/4] rust: types: Add Ownable/Owned types
On Tue Jul 8, 2025 at 3:22 PM CEST, Andreas Hindborg wrote:
> "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com> writes:
>> On Tue, Jul 8, 2025 at 11:57 AM Oliver Mangold <oliver.mangold@...e> wrote:
>>> Note, though, that I already moved it from types.rs to types/ownable.rs on
>>> request. It seems to me different people here have different ideas where it
>>> should be placed. I feel now, that it would make sense to come to an
>>> agreement between the interested parties about where it should finally be
>>> placed, before I move it again. Could I ask that we settle that question
>>> once and for all before my next revision?
>>
>> Yeah, if there is a disagreement with something said previously, then
>> it should be resolved before starting to ping-pong between approaches
>> with more and more patch versions. Reviewers can forget or they may
>> not have read an earlier comment, but you did the right thing
>> mentioning there is such a conflict in opinions.
>
> Didn't we start with this placed in the top level kernel crate?
>
> Anyway, I think it should go next to `ARef` and `AlwaysRefCounted`,
> which is in `types`. I think I asked to have it moved to a submodule at
> some point to keep types.rs manageable.
I don't think we should have the `types` module at all, see my other
response.
> If we place this one to top level, we should move `ARef` and
> `AlwaysRefCounted` as well.
I already created an issue [1] & a patch was sent [2].
[1]: https://github.com/Rust-for-Linux/linux/issues/1173
[2]: https://lore.kernel.org/rust-for-linux/20250623192530.266103-1-shankari.ak0208@gmail.com/
---
Cheers,
Benno
Powered by blists - more mailing lists