linux-kernel - Re: [PATCH v2] fsi: make fsi_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36700745-a406-43ea-b623-f7033e33deb5@linux.ibm.com>
Date: Tue, 8 Jul 2025 10:05:08 -0500
From: Eddie James <eajames@...ux.ibm.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc: Ninad Palsule <ninad@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org
Subject: Re: [PATCH v2] fsi: make fsi_bus_type constant


On 7/1/25 07:07, Greg Kroah-Hartman wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the fsi_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.


Reviewed-by: Eddie James <eajames@...ux.ibm.com>


Thanks Greg.


>
> Cc: Eddie James <eajames@...ux.ibm.com>
> Cc: Ninad Palsule <ninad@...ux.ibm.com>
> Cc: linux-fsi@...ts.ozlabs.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
> v2: fix up subject line to be correct
>
>   drivers/fsi/fsi-core.c | 2 +-
>   include/linux/fsi.h    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
> index 50e8736039fe..ee39d1699387 100644
> --- a/drivers/fsi/fsi-core.c
> +++ b/drivers/fsi/fsi-core.c
> @@ -1404,7 +1404,7 @@ void fsi_driver_unregister(struct fsi_driver *fsi_drv)
>   }
>   EXPORT_SYMBOL_GPL(fsi_driver_unregister);
>   
> -struct bus_type fsi_bus_type = {
> +const struct bus_type fsi_bus_type = {
>   	.name		= "fsi",
>   	.match		= fsi_bus_match,
>   };
> diff --git a/include/linux/fsi.h b/include/linux/fsi.h
> index 8c5eef808788..adea1b432f2d 100644
> --- a/include/linux/fsi.h
> +++ b/include/linux/fsi.h
> @@ -68,7 +68,7 @@ extern int fsi_slave_read(struct fsi_slave *slave, uint32_t addr,
>   extern int fsi_slave_write(struct fsi_slave *slave, uint32_t addr,
>   		const void *val, size_t size);
>   
> -extern struct bus_type fsi_bus_type;
> +extern const struct bus_type fsi_bus_type;
>   extern const struct device_type fsi_cdev_type;
>   
>   enum fsi_dev_type {