linux-kernel - Re: [PATCH iwl-next v1] igbvf: remove unused fields from struct igbvf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250708153824.GM452973@horms.kernel.org>
Date: Tue, 8 Jul 2025 16:38:24 +0100
From: Simon Horman <horms@...nel.org>
To: Yuto Ohnuki <ytohnuki@...zon.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Kohei Enju <enjuk@...zon.com>
Subject: Re: [PATCH iwl-next v1] igbvf: remove unused fields from struct
 igbvf_adapter

On Mon, Jul 07, 2025 at 07:01:17PM +0100, Yuto Ohnuki wrote:
> Remove following unused fields from struct igbvf_adapter that are never
> referenced in the driver.
> 
> - blink_timer
> - eeprom_wol
> - fc_autoneg
> - int_mode
> - led_status
> - mng_vlan_id
> - polling_interval
> - rx_dma_failed
> - test_icr
> - test_rx_ring
> - test_tx_ring
> - tx_dma_failed
> - tx_fifo_head
> - tx_fifo_size
> - tx_head_addr
> 
> Also removed the following fields from struct igbvf_adapter since they
> are never read or used after initialization by igbvf_probe() and igbvf_sw_init().
> 
> - bd_number
> - rx_abs_int_delay
> - tx_abs_int_delay
> - rx_int_delay
> - tx_int_delay
> 
> This changes simplify the igbvf driver by removing unused fields, which
> improves maintenability.
> 
> Tested-by: Kohei Enju <enjuk@...zon.com>
> Signed-off-by: Yuto Ohnuki <ytohnuki@...zon.com>
> ---
>  drivers/net/ethernet/intel/igbvf/igbvf.h  | 25 -----------------------
>  drivers/net/ethernet/intel/igbvf/netdev.c |  7 -------
>  2 files changed, 32 deletions(-)

Less is more :)

Reviewed-by: Simon Horman <horms@...nel.org>