linux-kernel - Re: [PATCH net] net: phy: Don't register LEDs for genphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3aae1c17-2ce8-4229-a397-a8a25cc58fe9@linux.dev>
Date: Tue, 8 Jul 2025 11:52:26 -0400
From: Sean Anderson <sean.anderson@...ux.dev>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
 Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
 "David S . Miller" <davem@...emloft.net>,
 Florian Fainelli <f.fainelli@...il.com>, Eric Dumazet <edumazet@...gle.com>,
 Christian Marangi <ansuelsmth@...il.com>
Subject: Re: [PATCH net] net: phy: Don't register LEDs for genphy

On 7/7/25 19:32, Jakub Kicinski wrote:
> On Mon,  7 Jul 2025 15:58:03 -0400 Sean Anderson wrote:
>> -	if (IS_ENABLED(CONFIG_PHYLIB_LEDS))
>> +	if (IS_ENABLED(CONFIG_PHYLIB_LEDS) && !phy_driver_is_genphy(phydev) &&
>> +	    !phy_driver_is_genphy_10g(phydev))
> 
> Breaks build for smaller configs:
> 
> drivers/net/phy/phy_device.c: In function ‘phy_probe’:
> drivers/net/phy/phy_device.c:3506:14: error: implicit declaration of function ‘phy_driver_is_genphy_10g’; did you mean ‘phy_driver_is_genphy’? [-Werror=implicit-function-declaration]
>  3506 |             !phy_driver_is_genphy_10g(phydev))
>       |              ^~~~~~~~~~~~~~~~~~~~~~~~
>       |              phy_driver_is_genphy

This is due to
https://github.com/linux-netdev/testing/commit/42ed7f7e94da01391d3519ffb5747698d2be0a67
which is not in net/main yet.

--Sean