linux-kernel - Re: [PATCH v2 28/28] interconnect: qcom: icc-rpmh: drop support for non-dynamic IDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cef8c989-4a0a-44dd-b0b6-15454f98193e@oss.qualcomm.com>
Date: Tue, 8 Jul 2025 18:44:06 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
        Georgi Djakov <djakov@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 28/28] interconnect: qcom: icc-rpmh: drop support for
 non-dynamic IDS

On 7/4/25 6:35 PM, Dmitry Baryshkov wrote:
> Now as all RPMh interconnect drivers were converted to using the dynamic
> IDs, drop support for non-dynamic ID allocation.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---

[...]

> diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/qcom/icc-rpmh.c
> index 941692cbaf208c66a27dda2e6902b2f26f605840..796fba9fb316cf58ae2eb77af1607d6d00c38438 100644
> --- a/drivers/interconnect/qcom/icc-rpmh.c
> +++ b/drivers/interconnect/qcom/icc-rpmh.c
> @@ -280,14 +280,10 @@ int qcom_icc_rpmh_probe(struct platform_device *pdev)
>  		if (!qn)
>  			continue;
>  
> -		if (desc->alloc_dyn_id) {
> -			if (!qn->node)
> -				qn->node = icc_node_create_dyn();
> -			node = qn->node;
> -		} else {
> -			node = icc_node_create(qn->id);
> -		}
> +		if (!qn->node)
> +			qn->node = icc_node_create_dyn();
>  
> +		node = qn->node;

we can drop the 'node' binding now, I think

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad