linux-kernel - Re: [PATCH] drbd: add missing kref_get in handle_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175199761446.1185853.16712742207654241158.b4-ty@kernel.dk>
Date: Tue, 08 Jul 2025 12:00:14 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Christoph Böhmwalder <christoph.boehmwalder@...bit.com>
Cc: drbd-dev@...ts.linbit.com, linux-kernel@...r.kernel.org, 
 Lars Ellenberg <lars.ellenberg@...bit.com>, 
 Philipp Reisner <philipp.reisner@...bit.com>, linux-block@...r.kernel.org, 
 Sarah Newman <srn@...mr.com>, Lars Ellenberg <lars@...bit.com>
Subject: Re: [PATCH] drbd: add missing kref_get in handle_write_conflicts


On Fri, 27 Jun 2025 11:57:28 +0200, Christoph Böhmwalder wrote:
> With `two-primaries` enabled, DRBD tries to detect "concurrent" writes
> and handle write conflicts, so that even if you write to the same sector
> simultaneously on both nodes, they end up with the identical data once
> the writes are completed.
> 
> In handling "superseeded" writes, we forgot a kref_get,
> resulting in a premature drbd_destroy_device and use after free,
> and further to kernel crashes with symptoms.
> 
> [...]

Applied, thanks!

[1/1] drbd: add missing kref_get in handle_write_conflicts
      commit: 00c9c9628b49e368d140cfa61d7df9b8922ec2a8

Best regards,
-- 
Jens Axboe