linux-kernel - Re: [PATCH] squashfs: Fix incorrect argument to sizeof in kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47a56ddc-eedc-40f4-a7a1-1aeea6224e1c@squashfs.org.uk>
Date: Tue, 8 Jul 2025 20:05:10 +0100
From: Phillip Lougher <phillip@...ashfs.org.uk>
To: Colin Ian King <colin.i.king@...il.com>, Chanho Min <chanho.min@....com>
Cc: kernel-janitors@...r.kernel.org, Andrew Morton
 <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] squashfs: Fix incorrect argument to sizeof in
 kmalloc_array call

On 08/07/2025 15:26, Colin Ian King wrote:
> The sizeof(void *) is the incorrect argument in the kmalloc_array call,
> it best to fix this by using sizeof(*folio) instead. Fortunately the
> sizes of void * and *folio happen to be the same, so this has not shown
> up as a run time issue.
> 
> Fixes: 2e227ff5e272 ("squashfs: add optional full compressed block caching")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Thanks

Reviewed-by: Phillip Lougher <phillip@...ashfs.org.uk>

> ---
>   fs/squashfs/block.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/squashfs/block.c b/fs/squashfs/block.c
> index b3ae3b1cc0e5..00049b7b10c8 100644
> --- a/fs/squashfs/block.c
> +++ b/fs/squashfs/block.c
> @@ -89,7 +89,7 @@ static int squashfs_bio_read_cached(struct bio *fullbio,
>   	int err = 0;
>   #ifdef CONFIG_SQUASHFS_COMP_CACHE_FULL
>   	struct folio **cache_folios = kmalloc_array(page_count,
> -			sizeof(void *), GFP_KERNEL | __GFP_ZERO);
> +			sizeof(*folio), GFP_KERNEL | __GFP_ZERO);
>   #endif
>   
>   	bio_for_each_folio_all(fi, fullbio) {