linux-kernel - Re: [PATCH net-next v4 1/2] dt-bindings: net: Add support for SpacemiT K1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c917152-0260-4442-a944-3cc0b3356e04@iscas.ac.cn>
Date: Tue, 8 Jul 2025 10:19:38 +0800
From: Vivian Wang <wangruikang@...as.ac.cn>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
 Eric Dumazet <edumazet@...gle.com>, Junhui Liu <junhui.liu@...moral.tech>,
 Conor Dooley <conor.dooley@...rochip.com>, netdev@...r.kernel.org,
 Philipp Zabel <p.zabel@...gutronix.de>, Jakub Kicinski <kuba@...nel.org>,
 linux-riscv@...ts.infradead.org, Simon Horman <horms@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, devicetree@...r.kernel.org,
 Vivian Wang <uwu@...m.page>, Yixun Lan <dlan@...too.org>,
 spacemit@...ts.linux.dev, Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Paolo Abeni <pabeni@...hat.com>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: Add support for
 SpacemiT K1

On 7/3/25 20:31, Vivian Wang wrote:
>
> On 7/3/25 18:49, Rob Herring (Arm) wrote:
>> On Thu, 03 Jul 2025 17:42:02 +0800, Vivian Wang wrote:
>>> The Ethernet MACs on SpacemiT K1 appears to be a custom design.
>>> SpacemiT
>>> refers to them as "EMAC", so let's just call them "spacemit,k1-emac".
>>>
>>> Signed-off-by: Vivian Wang <wangruikang@...as.ac.cn>
>>> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
>>> ---
>>>   .../devicetree/bindings/net/spacemit,k1-emac.yaml  | 81
>>> ++++++++++++++++++++++
>>>   1 file changed, 81 insertions(+)
>>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Error:
>> Documentation/devicetree/bindings/net/spacemit,k1-emac.example.dts:36.36-37
>> syntax error
>> FATAL ERROR: Unable to parse input tree
>
> My bad. The example still depends on the reset bindings for the
> constant RESET_EMAC0. I just tried with reset v12 [1] and that fixes it.
>
> [1]:
> https://lore.kernel.org/spacemit/20250702113709.291748-2-elder@riscstar.com/
>
> Vivian "dramforever" Wang 
>
Just for the record for anyone watching this thread, I'm most likely
going to be holding off sending the next version of this until reset v12
(probably?) gets at least taken up by a maintainer.

It's a bit of a weird situation over there since they're sending the
reset controller stuff through the clk tree, but then it's also a
mega-syscon situation for the K1 and that's how they decided they want
it, so it is what it is.

(The DMA bus dependency that was in v3 is all DTS changes with no
bindings and no driver, so that could be easily handled entirely in the
SpacemiT SoC tree, which is nice.)

Vivian

>> [...]