linux-kernel - Re: [PATCH v6 11/30] x86,fs/resctrl: Rename some L3 specific functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a786c63-0cf3-4d23-b9a2-623424c88f02@intel.com>
Date: Tue, 8 Jul 2025 14:08:23 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Anil Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v6 11/30] x86,fs/resctrl: Rename some L3 specific
 functions

Hi Tony,

On 6/26/25 9:49 AM, Tony Luck wrote:
> All monitor functions used to be tied to the RDT_RESOURCE_L3 resource,
> so generic function names to setup and tear down domains made sense.

"All monitor functions are tied to the RDT_RESOURCE_L3 resource,
so generic function names to setup and tear down domains makes sense."

> But with the arrival of monitor events tied to other domains it would
> be clearer if these functions were more accurately named.

"With the arrival of monitor events tied to new domains associated with
different resources it would be clearer if these functions are more
accurately named."
 
> Two groups of functions renamed here:
> 
> Functions that allocate/free architecture per-RMID mbm state information:

mbm -> MBM

> arch_domain_mbm_alloc()		-> l3_mon_domain_mbm_alloc()
> mon_domain_free()		-> l3_mon_domain_free()
> 
> Functions that allocate/free filesystem per-RMID mbm state information:

mbm -> MBM

> domain_setup_mon_state()	-> domain_setup_l3_mon_state()
> domain_destroy_mon_state()	-> domain_destroy_l3_mon_state()
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

Patch looks good to me.

Reinette