linux-kernel - Re: [PATCH v4 4/5] mm/filemap: add write_begin_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tencent_28C38B580EFE8219F5D7E850944CC55A2106@qq.com>
Date: Tue, 8 Jul 2025 10:40:52 +0800
From: Taotao Chen <chentao325@...com>
To: Matthew Wilcox <willy@...radead.org>,
 陈涛涛 Taotao Chen <chentaotao@...iglobal.com>
Cc: "tytso@....edu" <tytso@....edu>, "hch@...radead.org" <hch@...radead.org>,
 "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
 "brauner@...nel.org" <brauner@...nel.org>,
 "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>,
 "rodrigo.vivi@...el.com" <rodrigo.vivi@...el.com>,
 "tursulin@...ulin.net" <tursulin@...ulin.net>,
 "airlied@...il.com" <airlied@...il.com>,
 "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
 "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
 "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
 "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "linux-mm@...ck.org" <linux-mm@...ck.org>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "frank.li@...o.com" <frank.li@...o.com>
Subject: Re: [PATCH v4 4/5] mm/filemap: add write_begin_get_folio() helper
 function


在 2025/7/7 22:54, Matthew Wilcox 写道:
> On Mon, Jul 07, 2025 at 07:00:33AM +0000, 陈涛涛 Taotao Chen wrote:
>> +++ b/mm/filemap.c
> I think this should be a static inline function.  I don't think it's
> worth moving out of line.  Of course if you have measurements that show
> differently, you can change my mind.
>
>> +/**
>> + * write_begin_get_folio - Get folio for write_begin with flags
>> + * @iocb: kiocb passed from write_begin (may be NULL)
>> + * @mapping: the address space to search in
>> + * @index: page cache index
>> + * @len: length of data being written
>> + *
>> + * This is a helper for filesystem write_begin() implementations.
>> + * It wraps __filemap_get_folio(), setting appropriate flags in
>> + * the write begin context.
>> + *
>> + * Returns a folio or an ERR_PTR.
> We prefer:
>
>   * Return: A folio or an ERR_PTR
>
> as this gets its own section in the kernel-doc output.

Hi,

I’ll update both in the next version. Thanks for your review!

--Taotao