linux-kernel - Re: [EXT] Re: [PATCH v4 2/4] media: ox05b1s: Add omnivision OX05B1S raw sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG2tECZaT3IsOV0z@kekkonen.localdomain>
Date: Tue, 8 Jul 2025 23:43:12 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Mirela Rabulea <mirela.rabulea@....com>
Cc: mchehab@...nel.org, hverkuil-cisco@...all.nl,
	laurent.pinchart+renesas@...asonboard.com, robh@...nel.org,
	krzk+dt@...nel.org, bryan.odonoghue@...aro.org,
	laurentiu.palcu@....com, robert.chiras@....com,
	jai.luthra@...asonboard.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, LnxRevLi@....com,
	kieran.bingham@...asonboard.com, hdegoede@...hat.com,
	dave.stevenson@...pberrypi.com, mike.rudenko@...il.com,
	alain.volmat@...s.st.com, devicetree@...r.kernel.org,
	conor+dt@...nel.org, alexander.stein@...tq-group.com,
	umang.jain@...asonboard.com, zhi.mao@...iatek.com, festevam@...x.de,
	julien.vuillaumier@....com
Subject: Re: [EXT] Re: [PATCH v4 2/4] media: ox05b1s: Add omnivision OX05B1S
 raw sensor driver

Hi Mirela,

On Tue, Jul 08, 2025 at 08:09:25PM +0300, Mirela Rabulea wrote:
> Hi Sakari & all,
> 
> On 6/29/25 11:30, Sakari Ailus wrote:
> > Caution: This is an external email. Please take care when clicking links
> > or opening attachments. When in doubt, report the message using the
> > 'Report this email' button
> > 
> > 
> > Hi Mirela,
> > 
> > On 3/5/25 11:43, Mirela Rabulea wrote:
> > > +struct ox05b1s_reg {
> > > +     u32 addr;
> > > +     u32 data;
> > > +};
> > 
> > Could you use struct reg_sequence instead, please?
> 
> Yes, sure, thanks for the hint.
> 
> Any other suggestions, anyone, before I send the next version?

Do you intend to align this with the common raw sensor model? It may still
take a while until we get those patches merged though, but the upside would
be there's on concern of backwards compatibility. We should discuss how to
implement HDR with that actually (Laurent is cc'd).

-- 
Regards,

Sakari Ailus