linux-kernel - Re: [PATCH] lib/crypto: sha256: Add tests for HMAC-SHA224 and HMAC-SHA256

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250708032605.GA3821@sol>
Date: Mon, 7 Jul 2025 20:26:05 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Jason A . Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH] lib/crypto: sha256: Add tests for HMAC-SHA224 and
 HMAC-SHA256

On Tue, Jul 08, 2025 at 01:09:17PM +1000, Ard Biesheuvel wrote:
> On Wed, 25 Jun 2025 at 17:12, Eric Biggers <ebiggers@...nel.org> wrote:
> >
> > Now that there's a library API for HMAC-SHA224 and HMAC-SHA256, update
> > sha224_kunit and sha256_kunit to test it.  This mirrors the tests for
> > HMAC-SHA384 and HMAC-SHA512 in sha384_kunit and sha512_kunit.  The test
> > vectors were generated using scripts/crypto/gen-hash-testvecs.py.
> >
> > Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> > ---
> >
> 
> 
> Acked-by: Ard Biesheuvel <ardb@...nel.org>
> 

Thanks!  FYI, the latest version of the tests is in
"[PATCH v4 0/4] KUnit tests for SHA-2 and Poly1305"
(https://lore.kernel.org/linux-crypto/20250706232817.179500-1-ebiggers@kernel.org/).
Sorry for the confusion -- this was an incremental patch, which was
superseded when I started a series for the tests from a clean state.

- Eric