linux-kernel - Re: [PATCH ath-next] wifi: ath12k: pack HTT pdev rate stats structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <074969cf-676a-34eb-c2e3-219cab3658d4@oss.qualcomm.com>
Date: Tue, 8 Jul 2025 09:28:41 +0530
From: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@....qualcomm.com>
To: Jeff Johnson <jeff.johnson@....qualcomm.com>,
        Jeff Johnson <jjohnson@...nel.org>,
        Aditya Kumar Singh <aditya.kumar.singh@....qualcomm.com>,
        Lingbo Kong <quic_lingbok@...cinc.com>
Cc: linux-wireless@...r.kernel.org, ath12k@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH ath-next] wifi: ath12k: pack HTT pdev rate stats structs



On 7/3/2025 2:59 AM, Jeff Johnson wrote:
> In order to ensure the HTT DebugFS structs shared with firmware have
> matching alignment, the structs should be packed. Most of the structs
> are correctly packed, however the following are not:
> 
> ath12k_htt_tx_pdev_rate_stats_tlv
> ath12k_htt_rx_pdev_rate_stats_tlv
> ath12k_htt_rx_pdev_rate_ext_stats_tlv
> 
> So pack those structs.
> 
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00284-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Fixes: ba42b22aa336 ("wifi: ath12k: Dump PDEV transmit rate HTT stats")
> Fixes: a24cd7583003 ("wifi: ath12k: Dump PDEV receive rate HTT stats")
> Fixes: 7a3e8eec8d18 ("wifi: ath12k: Dump additional PDEV receive rate HTT stats")
> Signed-off-by: Jeff Johnson <jeff.johnson@....qualcomm.com>

Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@....qualcomm.com>