linux-kernel - Re: [PATCH bpf-next 1/6] bpf: Add attach_type in bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507081130.devFCURB-lkp@intel.com>
Date: Tue, 8 Jul 2025 12:10:12 +0800
From: kernel test robot <lkp@...el.com>
To: Tao Chen <chen.dylane@...ux.dev>, ast@...nel.org, daniel@...earbox.net,
	john.fastabend@...il.com, andrii@...nel.org, martin.lau@...ux.dev,
	eddyz87@...il.com, song@...nel.org, yonghong.song@...ux.dev,
	kpsingh@...nel.org, sdf@...ichev.me, haoluo@...gle.com,
	jolsa@...nel.org, mattbobrowski@...gle.com, rostedt@...dmis.org,
	mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, kuniyu@...zon.com,
	willemb@...gle.com, jakub@...udflare.com, pablo@...filter.org,
	kadlec@...filter.org, hawk@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next 1/6] bpf: Add attach_type in bpf_link

Hi Tao,

kernel test robot noticed the following build errors:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Tao-Chen/bpf-Add-attach_type-in-bpf_link/20250707-234517
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20250707153916.802802-2-chen.dylane%40linux.dev
patch subject: [PATCH bpf-next 1/6] bpf: Add attach_type in bpf_link
config: i386-randconfig-015-20250708 (https://download.01.org/0day-ci/archive/20250708/202507081130.devFCURB-lkp@intel.com/config)
compiler: clang version 20.1.7 (https://github.com/llvm/llvm-project 6146a88f60492b520a36f8f8f3231e15f3cc6082)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250708/202507081130.devFCURB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507081130.devFCURB-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/netkit.c:778:32: error: too few arguments to function call, expected 5, have 4
     777 |         bpf_link_init(&nkl->link, BPF_LINK_TYPE_NETKIT,
         |         ~~~~~~~~~~~~~
     778 |                       &netkit_link_lops, prog);
         |                                              ^
   include/linux/bpf.h:2534:6: note: 'bpf_link_init' declared here
    2534 | void bpf_link_init(struct bpf_link *link, enum bpf_link_type type,
         |      ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2535 |                    const struct bpf_link_ops *ops, struct bpf_prog *prog,
         |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2536 |                    enum bpf_attach_type attach_type);
         |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +778 drivers/net/netkit.c

35dfaad7188cdc Daniel Borkmann 2023-10-24  770  
35dfaad7188cdc Daniel Borkmann 2023-10-24  771  static int netkit_link_init(struct netkit_link *nkl,
35dfaad7188cdc Daniel Borkmann 2023-10-24  772  			    struct bpf_link_primer *link_primer,
35dfaad7188cdc Daniel Borkmann 2023-10-24  773  			    const union bpf_attr *attr,
35dfaad7188cdc Daniel Borkmann 2023-10-24  774  			    struct net_device *dev,
35dfaad7188cdc Daniel Borkmann 2023-10-24  775  			    struct bpf_prog *prog)
35dfaad7188cdc Daniel Borkmann 2023-10-24  776  {
35dfaad7188cdc Daniel Borkmann 2023-10-24  777  	bpf_link_init(&nkl->link, BPF_LINK_TYPE_NETKIT,
35dfaad7188cdc Daniel Borkmann 2023-10-24 @778  		      &netkit_link_lops, prog);
35dfaad7188cdc Daniel Borkmann 2023-10-24  779  	nkl->location = attr->link_create.attach_type;
35dfaad7188cdc Daniel Borkmann 2023-10-24  780  	nkl->dev = dev;
35dfaad7188cdc Daniel Borkmann 2023-10-24  781  	return bpf_link_prime(&nkl->link, link_primer);
35dfaad7188cdc Daniel Borkmann 2023-10-24  782  }
35dfaad7188cdc Daniel Borkmann 2023-10-24  783  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki