linux-kernel - RE: [Intel-wired-lan] [PATCH] [v2] ethernet: intel: fix building with large NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB7522E19A5C157371EC184179A04EA@PH0PR11MB7522.namprd11.prod.outlook.com>
Date: Tue, 8 Jul 2025 06:20:47 +0000
From: "Mekala, SunithaX D" <sunithax.d.mekala@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Arnd Bergmann <arnd@...db.de>, Simon Horman <horms@...nel.org>, "Dr. David
 Alan Gilbert" <linux@...blig.org>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, Dawid Osuchowski
	<dawid.osuchowski@...ux.intel.com>, "Jagielski, Jedrzej"
	<jedrzej.jagielski@...el.com>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, "Kwapulinski, Piotr"
	<piotr.kwapulinski@...el.com>, "Mrozowicz, SlawomirX"
	<slawomirx.mrozowicz@...el.com>, Martyna Szapar-Mudlaw
	<martyna.szapar-mudlaw@...ux.intel.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH] [v2] ethernet: intel: fix building with
 large NR_CPUS

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Arnd Bergmann
> Sent: Friday, June 20, 2025 10:31 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric Dumazet >  <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>
> Cc: Arnd Bergmann <arnd@...db.de>; Simon Horman <horms@...nel.org>; Dr. David Alan Gilbert <linux@...blig.org>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Dawid Osuchowski >  <dawid.osuchowski@...ux.intel.com>; Jagielski, Jedrzej <jedrzej.jagielski@...el.com>; Polchlopek, Mateusz <mateusz.polchlopek@...el.com>; Kwapulinski, Piotr <piotr.kwapulinski@...el.com>; Mrozowicz, SlawomirX >  <slawomirx.mrozowicz@...el.com>; Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>; intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
>  Subject: [Intel-wired-lan] [PATCH] [v2] ethernet: intel: fix building with large NR_CPUS
> 
> From: Arnd Bergmann <arnd@...db.de>
>
> With large values of CONFIG_NR_CPUS, three Intel ethernet drivers fail to
> compile like:
>
> In function ‘i40e_free_q_vector’,
>     inlined from ‘i40e_vsi_alloc_q_vectors’ at drivers/net/ethernet/intel/i40e/i40e_main.c:12112:3:
>   571 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> include/linux/rcupdate.h:1084:17: note: in expansion of macro ‘BUILD_BUG_ON’
>  1084 |                 BUILD_BUG_ON(offsetof(typeof(*(ptr)), rhf) >= 4096);    \
> drivers/net/ethernet/intel/i40e/i40e_main.c:5113:9: note: in expansion of macro ‘kfree_rcu’
>  5113 |         kfree_rcu(q_vector, rcu);
>       |         ^~~~~~~~~
>
> The problem is that the 'rcu' member in 'q_vector' is too far from the start
> of the structure. Move this member before the CPU mask instead, in all three
> drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  v2: move rcu to just after the napi_struct [Alexander Lobakin]
> ---
>  drivers/net/ethernet/intel/fm10k/fm10k.h | 3 ++-
>  drivers/net/ethernet/intel/i40e/i40e.h   | 2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h | 3 ++-
>  3 files changed, 5 insertions(+), 3 deletions(-)

Tested-by: Sunitha Mekala <sunithax.d.mekala@...el.com> (A Contingent worker at Intel)