[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aGzEbw3BybnWOidx@kernel.org>
Date: Tue, 8 Jul 2025 10:10:39 +0300
From: Mike Rapoport <rppt@...nel.org>
To: Yann Ylavic <ylavic.dev@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Andy Lutomirski <luto@...nel.org>, Borislav Petkov <bp@...en8.de>,
Daniel Gomez <da.gomez@...sung.com>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Ingo Molnar <mingo@...hat.com>,
Luis Chamberlain <mcgrof@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Masami Hiramatsu <mhiramat@...nel.org>,
"H. Peter Anvin" <hpa@...or.com>,
Peter Zijlstra <peterz@...radead.org>,
Petr Pavlu <petr.pavlu@...e.com>,
Sami Tolvanen <samitolvanen@...gle.com>,
Steven Rostedt <rostedt@...dmis.org>,
Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, linux-modules@...r.kernel.org,
linux-trace-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 3/8] execmem: rework execmem_cache_free()
On Mon, Jul 07, 2025 at 05:32:11PM +0200, Yann Ylavic wrote:
> On Fri, Jul 4, 2025 at 3:54 PM Mike Rapoport <rppt@...nel.org> wrote:
> > +
> > +static void execmem_cache_free_slow(struct work_struct *work)
> > +{
> > + struct maple_tree *busy_areas = &execmem_cache.busy_areas;
> > + MA_STATE(mas, busy_areas, 0, ULONG_MAX);
> > + void *area;
> > +
> > + guard(mutex)(&execmem_cache.mutex);
> > +
> > + if (!execmem_cache.pending_free_cnt)
> > + return;
> > +
> > + mas_for_each(&mas, area, ULONG_MAX) {
> > + if (!is_pending_free(area))
> > + continue;
> > +
> > + pending_free_clear(area);
>
> Probably:
> area = pending_free_clear(area);
> ?
Right, thanks!
> > + if (__execmem_cache_free(&mas, area, GFP_KERNEL))
> > + continue;
> > +
> > + execmem_cache.pending_free_cnt--;
> > + }
> > +
> > + if (execmem_cache.pending_free_cnt)
> > + schedule_delayed_work(&execmem_cache_free_work, FREE_DELAY);
> > + else
> > + schedule_work(&execmem_cache_clean_work);
> > +}
>
>
> Regards;
> Yann.
--
Sincerely yours,
Mike.
Powered by blists - more mailing lists