linux-kernel - Re: [PATCH v2 2/2] pmdomain: qcom: rpmhpd: Add Milos power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250708-vengeful-bright-rhino-d8d5ea@krzk-bin>
Date: Tue, 8 Jul 2025 10:05:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Casey Connolly <casey.connolly@...aro.org>
Cc: Luca Weiss <luca.weiss@...rphone.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Bjorn Andersson <andersson@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>, 
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 2/2] pmdomain: qcom: rpmhpd: Add Milos power domains

On Mon, Jul 07, 2025 at 04:42:13PM +0200, Casey Connolly wrote:
> > > > diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
> > > > index 078323b85b5648e33dd89e08cf31bdc5ab76d553..e09552a469264f28952fc46c3ab8c125e87310da 100644
> > > > --- a/drivers/pmdomain/qcom/rpmhpd.c
> > > > +++ b/drivers/pmdomain/qcom/rpmhpd.c
> > > > @@ -217,6 +217,24 @@ static struct rpmhpd gmxc = {
> > > >    	.res_name = "gmxc.lvl",
> > > >    };
> > > > +/* Milos RPMH powerdomains */
> > > 
> > > I can't find any public docs telling us which SoC is Milos (the only
> > > relevant result is Bjorn's email asking you to use that name instead of
> > > SM7635). So for the sake of future generations could you reference both
> > > names in a comment somewhere? Or even the commit message would be enough
> > > tbh.
> > 
> > I don't know the full list of model numbers for Milos. I assume it's
> > SM7635, SM6650, SM6650P, QCM6690 and QCS6690 based on the info I could
> > fine, but such info is hard to get. So this is not a definite list that
> > all those are actually Milos, or that this is the full list of Milos
> > chipsets.
> 
> oof, I see... that complicates things. It sure would be good if this list
> was documented in the kernel though imo.

Kernel is not the place to store mappings or descriptions of some random
company products and their names, so no.

Also it's not a task of contributor of a new SoC to decipher Qualcomm
model numbering and document it anywhere.

Best regards,
Krzysztof