linux-kernel - Re: [PATCH 2/2] ARM: dts: BCM5301X: Add support for Buffalo WXR-1750DHP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250708-elite-indigo-wombat-faa74f@krzk-bin>
Date: Tue, 8 Jul 2025 10:34:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Taishi Shimizu <s.taishi14142@...il.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Hauke Mehrtens <hauke@...ke-m.de>, Rafal Milecki <zajec5@...il.com>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Stefan Wahren <wahrenst@....net>
Subject: Re: [PATCH 2/2] ARM: dts: BCM5301X: Add support for Buffalo
 WXR-1750DHP

On Thu, Jun 26, 2025 at 12:43:15AM +0900, Taishi Shimizu wrote:
> +
> +#include "bcm4708.dtsi"
> +#include "bcm5301x-nand-cs0-bch8.dtsi"
> +
> +/ {
> +	compatible = "buffalo,wxr-1750dhp", "brcm,bcm4708";
> +	model = "Buffalo WXR-1750DHP";
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200";

Please use stdout path property.

> +	};
> +
> +	memory@0 {
> +		reg = <0x00000000 0x08000000>,
> +		      <0x88000000 0x08000000>;
> +		device_type = "memory";
> +	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +
> +		button-aoss {
> +			label = "AOSS";
> +			linux,code = <KEY_WPS_BUTTON>;
> +			gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		/* GPIO 8 and 9 are a tri-state switch button with
> +		 * ROUTER / AP / WB.
> +		 */
> +		button-bridge {
> +			label = "WB";
> +			linux,code = <BTN_2>;
> +			linux,input-type = <EV_SW>;
> +			gpios = <&chipcommon 8 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		/* GPIO 3 is a switch button with AUTO / MANUAL. */
> +		button-manual {
> +			label = "MANUAL";
> +			linux,code = <BTN_0>;
> +			linux,input-type = <EV_SW>;
> +			gpios = <&chipcommon 3 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		button-restart {
> +			label = "Reset";
> +			linux,code = <KEY_RESTART>;
> +			gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		button-router {
> +			label = "ROUTER";
> +			linux,code = <BTN_1>;
> +			linux,input-type = <EV_SW>;
> +			gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-power0 {
> +			label = "bcm53xx:white:power";

You should use rather color and function properties.

> +			linux,default-trigger = "default-on";
> +			gpios = <&chipcommon 5 GPIO_ACTIVE_HIGH>;
> +		};

Best regards,
Krzysztof