linux-kernel - Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Add support for MT8189

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250708-aspiring-evasive-orangutan-fa7b74@krzk-bin>
Date: Tue, 8 Jul 2025 10:43:42 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Zexin Wang <ot_zexin.wang@...iatek.com>
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>, 
	Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, Project_Global_Chrome_Upstream_Group@...iatek.com, 
	linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Add support for
 MT8189

On Fri, Jun 27, 2025 at 05:44:20PM +0800, Zexin Wang wrote:
> Add compatible string for watchdog on MT8189 SoC.
> 
> Signed-off-by: Zexin Wang <ot_zexin.wang@...iatek.com>
> ---
>  Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> index 8d2520241e37..ad69bd28ac9e 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> @@ -29,6 +29,7 @@ properties:
>            - mediatek,mt8183-wdt
>            - mediatek,mt8186-wdt
>            - mediatek,mt8188-wdt
> +          - mediatek,mt8189-wdt

So it is compatible with previous variant. Express it and drop driver
patch. Your commit msg should already say that - describe the hardware.
Now your commit msg basically duplicates patch and subject so it is 100%
redundant.

Best regards,
Krzysztof