linux-kernel - Re: [PATCH 3/9] rust: block,core: rename `RawWriter` to `BufferWriter`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ikk3oyvh.fsf@kernel.org>
Date: Tue, 08 Jul 2025 10:44:34 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>
Cc: "Boqun Feng" <boqun.feng@...il.com>,  "Miguel Ojeda" <ojeda@...nel.org>,
  "Alex Gaynor" <alex.gaynor@...il.com>,  "Gary Guo" <gary@...yguo.net>,
  Björn Roy Baron <bjorn3_gh@...tonmail.com>,  "Benno
 Lossin"
 <lossin@...nel.org>,  "Alice Ryhl" <aliceryhl@...gle.com>,  "Trevor Gross"
 <tmgross@...ch.edu>,  "Danilo Krummrich" <dakr@...nel.org>,  "Jens Axboe"
 <axboe@...nel.dk>,  <linux-block@...r.kernel.org>,
  <rust-for-linux@...r.kernel.org>,  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/9] rust: block,core: rename `RawWriter` to `BufferWriter`

"Miguel Ojeda" <miguel.ojeda.sandonis@...il.com> writes:

> On Mon, Jul 7, 2025 at 4:58 PM Andreas Hindborg <a.hindborg@...nel.org> wrote:
>>
>> The null insertion at the call site should be removed, it's a leftover
>> from before `BufferWriter` handled that.
>
> Just in case -- I think that if you do that then you would only get
> the null terminator at the end of the buffer.
>
> i.e. the one your formatter (`RawWriter`) places is really at the end
> of the buffer, rather than immediately after your formatted text, so
> if you don't have the one at the call site, you would end with garbage
> in the middle unless the disk name fits perfectly into the buffer.

I'll be sure to thoroughly check everything. Thanks for taking a look.


Best regards,
Andreas Hindborg