linux-kernel - Re: [PATCH 1/4] dt-bindings: power: Add A523 PPU and PCK600 power controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03211869-cd7d-4111-a7c1-3c69fccc4120@kernel.org>
Date: Tue, 8 Jul 2025 11:06:13 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: wens@...nel.org
Cc: Jernej Skrabec <jernej@...nel.org>, Samuel Holland <samuel@...lland.org>,
 Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Andre Przywara <andre.przywara@....com>,
 linux-sunxi@...ts.linux.dev, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: power: Add A523 PPU and PCK600 power
 controllers

On 08/07/2025 10:55, Chen-Yu Tsai wrote:
> On Tue, Jul 8, 2025 at 4:47 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On Fri, Jun 27, 2025 at 11:29:15PM +0800, Chen-Yu Tsai wrote:
>>> From: Chen-Yu Tsai <wens@...e.org>
>>>
>>> The A523 PPU is likely the same kind of hardware seen on previous SoCs.
>>>
>>> The A523 PCK600, as the name suggests, is likely a customized version
>>> of ARM's PCK-600 power controller. Comparing the BSP driver against
>>> ARM's PPU datasheet shows that the basic registers line up, but
>>> Allwinner's hardware has some additional delay controls in the reserved
>>> register range. As such it is likely not fully compatible with the
>>> standard ARM version.
>>>
>>> Document A523 PPU and PCK600 compatibles.
>>>
>>> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
>>> ---
>>>  .../bindings/power/allwinner,sun20i-d1-ppu.yaml   |  2 ++
>>>  .../power/allwinner,sun55i-a523-pck600.h          | 15 +++++++++++++++
>>>  .../dt-bindings/power/allwinner,sun55i-a523-ppu.h | 12 ++++++++++++
>>>  3 files changed, 29 insertions(+)
>>>  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
>>>  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
>>> index f578be6a3bc8..b9f550994512 100644
>>> --- a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
>>> +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
>>> @@ -18,6 +18,8 @@ properties:
>>>      enum:
>>>        - allwinner,sun20i-d1-ppu
>>>        - allwinner,sun8i-v853-ppu
>>> +      - allwinner,sun55i-a523-ppu
>>> +      - allwinner,sun55i-a523-pck-600
>>
>> Don't add items at the end, but placed in alphabetical order. Could be
>> natural sort if you insist, but binding does not use it.
> 
> In our other bindings [1][2] we have them sorted by family (sunXYi)

Sure, choose whatever sorting rule you want but then YOU must review
this on every binding, because we do not and we cannot know that family
information.

But if this is the sorting here, why "20" is before 8? In other places
it is after.

So yeah, you have chosen complicated sorting which no one from DT
maintainers gets and you do not enforce clarify...

Best regards,
Krzysztof