linux-kernel - Re: [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aGxyD3mtzdNZPPnx@makrotopia.org>
Date: Tue, 8 Jul 2025 02:19:11 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: Rosen Penev <rosenp@...il.com>
Cc: linux-wireless@...r.kernel.org,
	Johannes Berg <johannes@...solutions.net>, yangshiji66@...com,
	ansuelsmth@...il.com, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Stanislaw Gruszka <stf_xl@...pl>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:MIPS" <linux-mips@...r.kernel.org>,
	"moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@...ts.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding

On Sun, Jul 06, 2025 at 02:41:11PM -0700, Rosen Penev wrote:
> MT7620A devices all contain a wifi device as part of the SOC. Add it
> here to get it working.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  arch/mips/boot/dts/ralink/mt7620a.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)

The commit title

MIPS: dts: ralink: mt7628a: add wifi binding 

seems wrong as the commit (correctly) touches mt7620a.dtsi and not
mt7628a.dtsi (which would be wrong as the WiFi part of MT7628A is
already supported by the mt76 driver and part of the device tree).
Also the word 'binding' seems wrong in this context, you are adding
a node to the device tree, not to the device tree bindings.

I'd hence suggest to change the commit title to

MIPS: dts: ralink: mt7620a: add wifi