linux-kernel - Re: [PATCH v11 1/4] rust: types: Add Ownable/Owned types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kWFYS-inzFPTQAGdPRBr7MffZLR9q7iWiT_j2w_e99MQ@mail.gmail.com>
Date: Tue, 8 Jul 2025 12:16:19 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Oliver Mangold <oliver.mangold@...me>
Cc: Benno Lossin <lossin@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Asahi Lina <lina+kernel@...hilina.net>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 1/4] rust: types: Add Ownable/Owned types

On Tue, Jul 8, 2025 at 11:57 AM Oliver Mangold <oliver.mangold@...me> wrote:
>
> Note, though, that I already moved it from types.rs to types/ownable.rs on
> request. It seems to me different people here have different ideas where it
> should be placed. I feel now, that it would make sense to come to an
> agreement between the interested parties about where it should finally be
> placed, before I move it again. Could I ask that we settle that question
> once and for all before my next revision?

Yeah, if there is a disagreement with something said previously, then
it should be resolved before starting to ping-pong between approaches
with more and more patch versions. Reviewers can forget or they may
not have read an earlier comment, but you did the right thing
mentioning there is such a conflict in opinions.

Cheers,
Miguel