linux-kernel - Re: [RFC/RFT PATCH 0/5] Clean up UFS(-qcom) MCQ situation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mh4vv3i64rfx4hog7vgw6hnqk2ehrxkhz45q4e3pg66ufqsx37@csffhmn5fwm2>
Date: Tue, 8 Jul 2025 16:58:31 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Konrad Dybcio <konradybcio@...nel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K. Petersen" <martin.petersen@...cle.com>, Asutosh Das <quic_asutoshd@...cinc.com>, 
	Bart Van Assche <bvanassche@....org>, Stanley Chu <stanley.chu@...iatek.com>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, Can Guo <quic_cang@...cinc.com>, 
	Nitin Rawat <quic_nitirawa@...cinc.com>, linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [RFC/RFT PATCH 0/5] Clean up UFS(-qcom) MCQ situation

On Fri, Jul 04, 2025 at 07:36:08PM GMT, Konrad Dybcio wrote:
> The initial implementation was quite messy, including requesting
> regions that do not really exist in hardware (or at least not in the
> way they were described).
> 
> As we have no users (and the corresponding dt-bindings were never even
> accepted), remove a whole lot of boilerplate code and clean up the
> software's expectations.
> 
> Note that this revision does not fix the bindings defficiency yet.
> 
> Compile-tested only & not the best code I've written, but I'm looking
> for feedback whether this approach is acceptable.
> 

I pushed for the bindings change within Qcom for a very long time, but it
didn't materialize. I don't think it makes sense to accept any series
targeting MCQ without bindings change (especially when it touches the memory
regions).

So please include the bindings change when you post the *real* series.

- Mani

> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> ---
> Konrad Dybcio (5):
>       ufs: ufs-qcom: Fix UFS base region name in MCQ case
>       ufs: ufs-qcom: Remove inferred MCQ mappings
>       ufs: ufs-qcom: Don't try to map inexistent regions
>       ufs: ufs-qcom: Rename "mcq_sqd" to "mcq_opr"
>       ufs: ufs-qcom: Kill ufshcd_res_info
> 
>  drivers/ufs/host/ufs-qcom.c      | 151 ++++++++++-----------------------------
>  drivers/ufs/host/ufs-qcom.h      |   4 ++
>  drivers/ufs/host/ufshcd-pltfrm.c |   4 +-
>  include/ufs/ufshcd.h             |  26 +------
>  4 files changed, 45 insertions(+), 140 deletions(-)
> ---
> base-commit: 26ffb3d6f02cd0935fb9fa3db897767beee1cb2a
> change-id: 20250704-topic-qcom_ufs_mcq_cleanup-3e7614ae06a8
> 
> Best regards,
> -- 
> Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> 

-- 
மணிவண்ணன் சதாசிவம்