linux-kernel - Re: [PATCH v3] wifi: wilc1000: Add error handling for wilc_sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b71db1e03da50e161b898a763bd01f6a1c8ce3e2.camel@sipsolutions.net>
Date: Tue, 08 Jul 2025 13:45:02 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Wentao Liang <vulab@...as.ac.cn>, ajay.kathat@...rochip.com, 
	claudiu.beznea@...on.dev, kvalo@...nel.org
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH v3] wifi: wilc1000: Add error handling for
 wilc_sdio_cmd52()

On Mon, 2025-05-19 at 16:42 +0800, Wentao Liang wrote:
> The wilc_sdio_read_size() calls wilc_sdio_cmd52() but does not check the
> return value. This could lead to execution with potentially invalid data
> if wilc_sdio_cmd52() fails. A proper implementation can be found in
> wilc_sdio_read_reg().
> 
> Add error handling for wilc_sdio_cmd52(). If wilc_sdio_cmd52() fails,
> log an error message via dev_err().

That's clearly hno longer true, please submit consistent patches.

Also, this change (at best!) addresses half the problem, please fix it
fully if you want to bother us with it at all.

johannes