linux-kernel - Re: [PATCH v2 0/6] xfs: cleanup key comparing routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175197602309.1155040.9466707632114261976.b4-ty@kernel.org>
Date: Tue, 08 Jul 2025 14:00:23 +0200
From: Carlos Maiolino <cem@...nel.org>
To: "Darrick J. Wong" <djwong@...nel.org>, 
 Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Christoph Hellwig <hch@....de>, linux-xfs@...r.kernel.org, 
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH v2 0/6] xfs: cleanup key comparing routines

On Wed, 02 Jul 2025 12:39:27 +0300, Fedor Pchelkin wrote:
> Key comparing routines are currently opencoded with extra casts and
> subtractions which is error prone and can be replaced with a neat
> cmp_int() helper which is now in a generic header file.
> 
> Started from:
> https://lore.kernel.org/linux-xfs/20250426134232.128864-1-pchelkin@ispras.ru/T/#u
> 
> [...]

Applied to for-next, thanks!

[1/6] xfs: rename diff_two_keys routines
      commit: c4c6aee6ba87fdfbaeed1966f81298e3f3913f3c
[2/6] xfs: rename key_diff routines
      commit: fb7eff8c9f1b7ac46b8e376f9da19d8996cd0262
[3/6] xfs: refactor cmp_two_keys routines to take advantage of cmp_int()
      commit: ff48e83c9dcd8c4f6b92b7d695ebe599c0a0e57d
[4/6] xfs: refactor cmp_key_with_cur routines to take advantage of cmp_int()
      commit: 786b3b2e16600a642ddf15bcaf94694cfc6b3250
[5/6] xfs: use a proper variable name and type for storing a comparison result
      commit: a0b2b28e1cc1c3c95bd889eec455bf8e68def61d
[6/6] xfs: refactor xfs_btree_diff_two_ptrs() to take advantage of cmp_int()
      commit: 10e4f0aebdadc94930e82ac13ef1e01abb0bda03

Best regards,
-- 
Carlos Maiolino <cem@...nel.org>