linux-kernel - Re: [PATCH net] net: ag71xx: Add missing check after DMA map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad66abc3-b90e-4eed-9e3d-f242c909e633@redhat.com>
Date: Tue, 8 Jul 2025 14:42:31 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Thomas Fourier <fourier.thomas@...il.com>
Cc: Chris Snook <chris.snook@...il.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ag71xx: Add missing check after DMA map

On 7/2/25 9:50 AM, Thomas Fourier wrote:
@@ -1275,7 +1281,7 @@ static int ag71xx_ring_rx_refill(struct ag71xx *ag)
>  
>  		if (!ring->buf[i].rx.rx_buf &&
>  		    !ag71xx_fill_rx_buf(ag, &ring->buf[i], offset,
> -					napi_alloc_frag))
> +					napi_alloc_frag, skb_free_frag))

I guess that if we merge this patch in the current form, we are going to
receive soon some automated-tool-generated patch removing the 'free'
argument.

It's probably better to avoid such argument from the start.

Thanks,

Paolo