linux-kernel - Re: [PATCH v2] rust: rbtree: simplify finding `current` in `remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DB6OQZFVOQ0A.1L90ENF8SAW3I@nvidia.com>
Date: Tue, 08 Jul 2025 21:51:13 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: Onur Özkan <work@...rozkan.dev>,
 <rust-for-linux@...r.kernel.org>
Cc: <linux-kernel@...r.kernel.org>, <ojeda@...nel.org>,
 <alex.gaynor@...il.com>, <boqun.feng@...il.com>, <gary@...yguo.net>,
 <bjorn3_gh@...tonmail.com>, <lossin@...nel.org>, <a.hindborg@...nel.org>,
 <aliceryhl@...gle.com>, <tmgross@...ch.edu>, <dakr@...nel.org>,
 <mattgilbride@...gle.com>, <wedsonaf@...il.com>, <daniel@...lak.dev>,
 <tamird@...il.com>
Subject: Re: [PATCH v2] rust: rbtree: simplify finding `current` in
 `remove_current`

On Tue Jul 8, 2025 at 4:58 PM JST, Onur Özkan wrote:
> The previous version used a verbose `match` to get
> `current`, which may be slightly confusing at first
> glance.
>
> This change makes it shorter and more clearly expresses
> the intent: prefer `next` if available, otherwise fall
> back to `prev`.
>
> Signed-off-by: Onur Özkan <work@...rozkan.dev>

Thanks, this is definitely easier to read.

Reviewed-by: Alexandre Courbot <acourbot@...dia.com>