linux-kernel - Re: [PATCH v4 6/6] block: use chunk_sectors when evaluating stacked atomic write limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d84e0629-28a4-4876-9395-4eb1d4bb280c@oracle.com>
Date: Tue, 8 Jul 2025 13:36:54 +0100
From: John Garry <john.g.garry@...cle.com>
To: Nilay Shroff <nilay@...ux.ibm.com>, agk@...hat.com, snitzer@...nel.org,
        mpatocka@...hat.com, song@...nel.org, yukuai3@...wei.com, hch@....de,
        axboe@...nel.dk, cem@...nel.org
Cc: dm-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-raid@...r.kernel.org, linux-block@...r.kernel.org,
        ojaswin@...ux.ibm.com, martin.petersen@...cle.com,
        akpm@...ux-foundation.org, linux-xfs@...r.kernel.org,
        djwong@...nel.org
Subject: Re: [PATCH v4 6/6] block: use chunk_sectors when evaluating stacked
 atomic write limits

On 08/07/2025 13:27, Nilay Shroff wrote:
>> +	if ((unsigned long)chunk_sectors << SECTOR_SHIFT > UINT_MAX)
>> +		chunk_bytes = chunk_sectors;
>> +	else
>> +		chunk_bytes = chunk_sectors << SECTOR_SHIFT;
>>   
> Can we use check_shl_overflow() here for checking overflow?

ok, I can change.

> Otherwise,
> changes look good to me. I've also tested it using my NVMe disk which
> supports up to 256kb of atomic writes.
 > > Reviewed-by: Nilay Shroff<nilay@...ux.ibm.com>
> Tested-by: Nilay Shroff<nilay@...ux.ibm.com>

thanks