linux-kernel - Re: [PATCH] iio: imu: inv_icm42600: fix temperature reading if accel/gyro is off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aG0Zyxno62z1eMXx@smile.fi.intel.com>
Date: Tue, 8 Jul 2025 16:14:51 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: imu: inv_icm42600: fix temperature reading if
 accel/gyro is off

On Tue, Jul 08, 2025 at 02:09:17PM +0200, Sean Nyekjaer wrote:
> Avoid return invalid argument if one tries to read the temperature,.

returning

(Stray period at the end)

> if both the accelerometer and gyro are off. Power the accelerometer on
> before reading the temperature.
> The original state will be restored by runtine_suspend() or the next
> reading of the accelerometer.

Why don't you use the room on the previous lines, the formatting looks ugly.

...

Does it need a Fixes tag?

...

Code wise LGTM, though.

-- 
With Best Regards,
Andy Shevchenko