linux-kernel - Re: [PATCH v2 12/13] uapi: linux: add mediatek isp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34fb8d81c07ff3f2bb2f679fef41b5c0f5afdeb1.camel@mediatek.com>
Date: Tue, 8 Jul 2025 01:34:31 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, Shangyao Lin (林上堯)
	<Shangyao.Lin@...iatek.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v2 12/13] uapi: linux: add mediatek isp_7x camsys user api

On Mon, 2025-07-07 at 09:31 +0800, shangyao lin wrote:
> From: "shangyao.lin" <shangyao.lin@...iatek.com>
> 
> Add UAPI for the MediaTek ISP platform, providing user-space interfaces for the
> new CAMSYS driver.
> 
> Changes in v2:
> - Moved V4L2 pixel format definitions to include/uapi/linux/videodev2.h
> 
> Notes:
> 
> Hi Laurent Pinchart and CK,
> 
> Thank you very much for your detailed feedback and suggestions.
> 
> I would like to let you know that in the next patch, I have added an initial
> version of an .rst document describing the MTK ISP CAMSYS controls. Most of
> these ISP CAMSYS controls are intended for other advanced features. For normal
> main-stream use cases, only controls such as V4L2_CID_MTK_CAM_RAW_RESOURCE_CALC
> are actually used.
> 
> Would you prefer that we remove the user space interfaces for these advanced
> features for now, and only add them back in a future patch series dedicated to
> advanced functionality? I am happy to follow your recommendation on this.

I suggest that you send the basic function first.
For you and the reviewer, the process would be much easier.
Reviewer review fewer codes, and you get fewer comment.
Advanced function could be sent later at any time you want.

Regards,
CK

> 
> Additionally, I have also written an initial version of a brief .rst document
> providing a high-level description of the hardware. If you think there is
> anything else that should be added or clarified, please kindly let me know.
> 
> Thank you again for your valuable feedback!
> 
> Best regards,
> Shangyao
> 
> Signed-off-by: shangyao.lin <shangyao.lin@...iatek.com>
> ---