linux-kernel - Re: [PATCH 1/2] clk: tegra: periph: Fix error handling and resolve unsigned compare warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jwlemmk4el6chr7fkzratg2si3s7rls3itq6ki7nbh4ssv3f4w@dxv5xnagtryr>
Date: Wed, 9 Jul 2025 14:08:04 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Pei Xiao <xiaopei01@...inos.cn>
Cc: pdeschrijver@...dia.com, pgaikwad@...dia.com, mturquette@...libre.com, 
	sboyd@...nel.org, linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] clk: tegra: periph: Fix error handling and resolve
 unsigned compare warning

On Wed, Jul 09, 2025 at 03:37:13PM +0800, Pei Xiao wrote:
> ./drivers/clk/tegra/clk-periph.c:59:5-9: WARNING:
> 	Unsigned expression compared with zero: rate < 0
> 
> The unsigned long 'rate' variable caused:
> - Incorrect handling of negative errors
> - Compile warning: "Unsigned expression compared with zero"
> 
> Fix by changing to long type and adding req->rate cast.
> 
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
> ---
>  drivers/clk/tegra/clk-periph.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)